Re: [PATCH v2] log: add log.follow config option

2015-07-08 Thread Junio C Hamano
Junio C Hamano writes: > David Turner writes: > >> diff --git a/revision.c b/revision.c >> index 3ff8723..ae6d4c3 100644 >> --- a/revision.c >> +++ b/revision.c >> @@ -2322,12 +2322,21 @@ int setup_revisions(int argc, const char **argv, >> struct rev_info *revs, struct s >> >> if (revs->

Re: [PATCH v2] log: add log.follow config option

2015-07-07 Thread Junio C Hamano
David Turner writes: >> IOW, I'd like to know why we need more than something like this >> change to this file, instead of the above? We didn't muck with >> revs->diff in the original when FOLLOW_RENAMES was set, but now it >> does, for example. > > We did, but we did it earlier. But I can just

Re: [PATCH v2] log: add log.follow config option

2015-07-07 Thread David Turner
On Tue, 2015-07-07 at 15:13 -0700, Junio C Hamano wrote: > David Turner writes: > > > diff --git a/revision.c b/revision.c > > index 3ff8723..ae6d4c3 100644 > > --- a/revision.c > > +++ b/revision.c > > @@ -2322,12 +2322,21 @@ int setup_revisions(int argc, const char **argv, > > struct rev_info

Re: [PATCH v2] log: add log.follow config option

2015-07-07 Thread Junio C Hamano
David Turner writes: > diff --git a/revision.c b/revision.c > index 3ff8723..ae6d4c3 100644 > --- a/revision.c > +++ b/revision.c > @@ -2322,12 +2322,21 @@ int setup_revisions(int argc, const char **argv, > struct rev_info *revs, struct s > > if (revs->prune_data.nr) { > co

Re: [PATCH v2] log: add log.follow config option

2015-07-07 Thread David Turner
On Tue, 2015-07-07 at 23:42 +0200, Matthieu Moy wrote: > Hi, > > Thanks for your patch. Below are some comments. Some of them are just me > thinking out loudly (don't take it badly if I'm being negative), some > are more serious, but all are fixable. Thanks for the feedback! > David Turner writ

Re: [PATCH v2] log: add log.follow config option

2015-07-07 Thread Matthieu Moy
Hi, Thanks for your patch. Below are some comments. Some of them are just me thinking out loudly (don't take it badly if I'm being negative), some are more serious, but all are fixable. David Turner writes: > From: David Turner If you configure your commiter id and your From field to the same

[PATCH v2] log: add log.follow config option

2015-07-07 Thread David Turner
From: David Turner Many users prefer to always use --follow with logs. Rather than aliasing the command, an option might be more convenient for some. --- Documentation/git-log.txt | 7 +++ builtin/log.c | 7 +++ diff.c | 5