Re: [PATCH v2] http.c: don't rewrite the user:passwd string multiple times

2013-06-18 Thread Jeff King
On Tue, Jun 18, 2013 at 07:43:49PM -0700, Brandon Casey wrote: > From: Brandon Casey > > Curl older than 7.17 (RHEL 4.X provides 7.12 and RHEL 5.X provides > 7.15) requires that we manage any strings that we pass to it as > pointers. So, we really shouldn't be modifying this strbuf after we > h

[PATCH v2] http.c: don't rewrite the user:passwd string multiple times

2013-06-18 Thread Brandon Casey
From: Brandon Casey Curl older than 7.17 (RHEL 4.X provides 7.12 and RHEL 5.X provides 7.15) requires that we manage any strings that we pass to it as pointers. So, we really shouldn't be modifying this strbuf after we have passed it to curl. Our interaction with curl is currently safe (before