Re: [PATCH v2] http: inform about alternates-as-redirects behavior

2017-03-06 Thread Brandon Williams
On 03/04, Jeff King wrote: > On Sat, Mar 04, 2017 at 08:36:45AM +, Eric Wong wrote: > > > I also think the security implications for relative alternates > > on the same host would not matter, since the smart HTTP will > > take them into account on the server side. > > It depends on the host w

Re: [PATCH v2] http: inform about alternates-as-redirects behavior

2017-03-04 Thread Jeff King
On Sat, Mar 04, 2017 at 08:36:45AM +, Eric Wong wrote: > I also think the security implications for relative alternates > on the same host would not matter, since the smart HTTP will > take them into account on the server side. It depends on the host whether all of the repos on it have the sa

[PATCH v2] http: inform about alternates-as-redirects behavior

2017-03-04 Thread Eric Wong
Jeff King wrote: > On Sat, Mar 04, 2017 at 06:55:48AM +, Eric Wong wrote: > > Jeff King wrote: > > > The warning itself: > > > > > > > + warning("alternate disabled by > > > > http.followRedirects!=true: %s", > > > > > > feels like it could use some whitespace around the "!="