Re: [PATCH v2] git submodule foreach: Skip eval for more than one argument

2013-09-27 Thread Johan Herland
On Fri, Sep 27, 2013 at 12:23 PM, Anders Kaseorg wrote: > ‘eval "$@"’ created an extra layer of shell interpretation, which was > probably not expected by a user who passed multiple arguments to git > submodule foreach: > > $ git grep "'" > [searches for single quotes] > $ git submodule foreach gi

[PATCH v2] git submodule foreach: Skip eval for more than one argument

2013-09-27 Thread Anders Kaseorg
‘eval "$@"’ created an extra layer of shell interpretation, which was probably not expected by a user who passed multiple arguments to git submodule foreach: $ git grep "'" [searches for single quotes] $ git submodule foreach git grep "'" Entering '[submodule]' /usr/lib/git-core/git-submodule: 1: