Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2014-01-17 Thread Junio C Hamano
Roman Kagan writes: > 2013/12/31 Roman Kagan : >> 2013/12/30 Junio C Hamano : >>> Roman Kagan writes: I'd like to note that it's IMO worth including in the 'maint' branch as it's a crasher. Especially so since the real fix has been merged in the subversion upstream and nominated

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2014-01-17 Thread Roman Kagan
2013/12/31 Roman Kagan : > 2013/12/30 Junio C Hamano : >> Roman Kagan writes: >>> I'd like to note that it's IMO worth including in the 'maint' branch >>> as it's a crasher. Especially so since the real fix has been merged >>> in the subversion upstream and nominated for 1.8 branch, so the >>> wo

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2014-01-06 Thread Andreas Stricker
Hi Roman >>> git-svn: workaround for a bug in svn serf backend (2013-12-27 20:22:19 >>> +) > Thanks! Well thanks to you for finding and fixing this bug that really annoyed me just before Christmas again. Your bug analysis proved my observation that even a fresh checkout (as I suggested in

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-30 Thread Roman Kagan
2013/12/30 Junio C Hamano : > Roman Kagan writes: >> I'd like to note that it's IMO worth including in the 'maint' branch >> as it's a crasher. Especially so since the real fix has been merged >> in the subversion upstream and nominated for 1.8 branch, so the >> workaround may soon lose its relev

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-30 Thread Junio C Hamano
Roman Kagan writes: > 2013/12/28 Junio C Hamano : >> Eric Wong writes: >>> git://git.bogomips.org/git-svn.git master >>> >>> for you to fetch changes up to 2394e94e831991348688831a384b088a424c7ace: >>> >>> git-svn: workaround for a bug in svn serf backend (2013-12-27 20:22:19 >>> +) >>>

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-28 Thread Roman Kagan
2013/12/28 Junio C Hamano : > Eric Wong writes: >> git://git.bogomips.org/git-svn.git master >> >> for you to fetch changes up to 2394e94e831991348688831a384b088a424c7ace: >> >> git-svn: workaround for a bug in svn serf backend (2013-12-27 20:22:19 >> +) >> >>

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-27 Thread Junio C Hamano
Eric Wong writes: > Jonathan Nieder wrote: >> Roman Kagan wrote: >> >> > Subversion serf backend in versions 1.8.5 and below has a bug that the >> > function creating the descriptor of a file change -- add_file() -- >> > doesn't make a copy of its third argument when storing it on the >> > retu

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-27 Thread Eric Wong
Jonathan Nieder wrote: > Roman Kagan wrote: > > > Subversion serf backend in versions 1.8.5 and below has a bug that the > > function creating the descriptor of a file change -- add_file() -- > > doesn't make a copy of its third argument when storing it on the > > returned descriptor. As a resul

Re: [PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-27 Thread Jonathan Nieder
Roman Kagan wrote: > Subversion serf backend in versions 1.8.5 and below has a bug that the > function creating the descriptor of a file change -- add_file() -- > doesn't make a copy of its third argument when storing it on the > returned descriptor. As a result, by the time this field is used (i

[PATCH v2] git-svn: workaround for a bug in svn serf backend

2013-12-27 Thread Roman Kagan
Subversion serf backend in versions 1.8.5 and below has a bug that the function creating the descriptor of a file change -- add_file() -- doesn't make a copy of its third argument when storing it on the returned descriptor. As a result, by the time this field is used (in transactions of file copyi