Thank you for the review Eric!
On 2019-09-12 at 20:20:11 +0200, Eric Sunshine wrote:
> On Thu, Sep 12, 2019 at 10:56 AM Tobias Klauser wrote:
> > v2:
> > - move whitespace trimming below defined'ness check as per Eric Sunshine's
> >review comment
> > diff --git a/perl/Git/SVN.pm b/perl/Git/
On Thu, Sep 12, 2019 at 10:56 AM Tobias Klauser wrote:
> v2:
> - move whitespace trimming below defined'ness check as per Eric Sunshine's
>review comment
> diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
> @@ -1494,6 +1494,7 @@ sub check_author {
> if (!defined $author || length $autho
In some cases, the svn author names might contain leading or trailing
whitespaces, leading to messages such as:
Author: user1
not defined in authors.txt
(the trailing newline leads to the line break). The user "user1" is
defined in authors.txt though, e.g.
user1 = User
Fix this by trimm
3 matches
Mail list logo
