Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes

2016-05-05 Thread Daurnimator
On 3 May 2016 at 11:21, Junio C Hamano wrote: > On Mon, May 2, 2016 at 4:56 PM, Daurnimator wrote: >> On 3 May 2016 at 07:57, Junio C Hamano wrote: >> >> I agree quiltimport should not, but I think filter-branch possibly >> should... at least for your *own* commits. >> I often think of filter-br

Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes

2016-05-02 Thread Junio C Hamano
On Mon, May 2, 2016 at 4:56 PM, Daurnimator wrote: > On 3 May 2016 at 07:57, Junio C Hamano wrote: > > I agree quiltimport should not, but I think filter-branch possibly > should... at least for your *own* commits. > I often think of filter-branch as an "advanced" `git commit --amend` But it doe

Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes

2016-05-02 Thread Daurnimator
On 3 May 2016 at 07:57, Junio C Hamano wrote: > I do not think this is particularly a good change. > > There are a few other in-tree users of "git commit-tree", > e.g. quiltimport and filter-branch, and their users would be hurt > the same way if they set commit.gpgsign in the configuration. I ag

Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes

2016-05-02 Thread Junio C Hamano
Cameron Currie writes: > This is helpful for folks with commit.gpgsign = true in their .gitconfig. > > Signed-off-by: Cameron Currie > --- I do not think this is particularly a good change. There are a few other in-tree users of "git commit-tree", e.g. quiltimport and filter-branch, and their

[PATCH v2] git-stash: Don't GPG sign when stashing changes

2016-05-02 Thread Cameron Currie
This is helpful for folks with commit.gpgsign = true in their .gitconfig. Signed-off-by: Cameron Currie --- git-stash.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/git-stash.sh b/git-stash.sh index c7c65e2..fcf01b9 100755 --- a/git-stash.sh +++ b/git-stash.sh @@ -8