Re: [PATCH v2] git-p4: Fix git-p4.mapUser on Windows

2017-01-30 Thread Junio C Hamano
Luke Diamand writes: > On 27 January 2017 at 17:33, Junio C Hamano wrote: >> >> Luke, Lars, this version seems to be in line with the conclusion of >> your earlier reviews, e.g. >> >> >> >> Even though it looks OK to my eyes, I'll wait for Acks or further >> refinement suggestions from either o

Re: [PATCH v2] git-p4: Fix git-p4.mapUser on Windows

2017-01-29 Thread Luke Diamand
On 27 January 2017 at 17:33, Junio C Hamano wrote: > George Vanburgh writes: > >> From: George Vanburgh >> >> When running git-p4 on Windows, with multiple git-p4.mapUser entries in >> git config - no user mappings are applied to the generated repository. >> ... >> Using splitlines solves this i

Re: [PATCH v2] git-p4: Fix git-p4.mapUser on Windows

2017-01-27 Thread Junio C Hamano
George Vanburgh writes: > From: George Vanburgh > > When running git-p4 on Windows, with multiple git-p4.mapUser entries in > git config - no user mappings are applied to the generated repository. > ... > Using splitlines solves this issue, by splitting config on all > typical delimiters ('\n',

[PATCH v2] git-p4: Fix git-p4.mapUser on Windows

2017-01-25 Thread George Vanburgh
From: George Vanburgh When running git-p4 on Windows, with multiple git-p4.mapUser entries in git config - no user mappings are applied to the generated repository. Reproduction Steps: 1. Add multiple git-p4.mapUser entries to git config on a Windows machine 2. Attempt to clone a p4 reposito