Re: [PATCH v2] fetch-pack: optionally save packs to disk

2015-06-12 Thread Jeff King
On Fri, Jun 12, 2015 at 02:00:05PM -0400, Jeff King wrote: > When I added GIT_TRACE_PACKET long ago, I had always intended to > follow-up with a GIT_TRACE_PACKFILE. The former stops tracing when we > get to the binary data, but I had intended the latter to store the pure > on-the-wire packfile tra

Re: [PATCH v2] fetch-pack: optionally save packs to disk

2015-06-12 Thread Jeff King
On Fri, Jun 12, 2015 at 08:07:36AM -0700, Junio C Hamano wrote: > Johannes Sixt writes: > > > What is the problem with the current fetch-pack implementation? Does > > it remove a bogus packfile after download? Does it abort during > > download when it detects a broken packfile? Does --keep not d

Re: [PATCH v2] fetch-pack: optionally save packs to disk

2015-06-12 Thread Augie Fackler
On Fri, Jun 12, 2015 at 11:07 AM, Junio C Hamano wrote: >> What is the problem with the current fetch-pack implementation? Does >> it remove a bogus packfile after download? Does it abort during >> download when it detects a broken packfile? Does --keep not do what >> you need? > > Doesn't the inc

Re: [PATCH v2] fetch-pack: optionally save packs to disk

2015-06-12 Thread Augie Fackler
On Fri, Jun 12, 2015 at 2:22 AM, Johannes Sixt wrote: > > Am 11.06.2015 um 20:59 schrieb Augie Fackler: >> >> When developing server software, it's often helpful to save a >> potentially-bogus pack for later analysis. This makes that trivial, >> instead of painful. > > > When you develop server so

Re: [PATCH v2] fetch-pack: optionally save packs to disk

2015-06-12 Thread Junio C Hamano
Johannes Sixt writes: > What is the problem with the current fetch-pack implementation? Does > it remove a bogus packfile after download? Does it abort during > download when it detects a broken packfile? Does --keep not do what > you need? Doesn't the incoming data still go through the fattenin

Re: [PATCH v2] fetch-pack: optionally save packs to disk

2015-06-11 Thread Johannes Sixt
Am 11.06.2015 um 20:59 schrieb Augie Fackler: When developing server software, it's often helpful to save a potentially-bogus pack for later analysis. This makes that trivial, instead of painful. When you develop server software, shouldn't you test drive the server via the bare metal protocol

[PATCH v2] fetch-pack: optionally save packs to disk

2015-06-11 Thread Augie Fackler
When developing server software, it's often helpful to save a potentially-bogus pack for later analysis. This makes that trivial, instead of painful. This is made a little complicated by the fact that in some cases (like cloning from smart-http, but not from a local repo) the fetch code reads the p