Re: [PATCH v2] column: show auto columns when pager is active

2017-10-23 Thread Kevin Daudt
On Mon, Oct 23, 2017 at 02:52:46PM -0700, Jonathan Nieder wrote: > Hi, > > Kevin Daudt wrote: > > > --- a/column.c > > +++ b/column.c > > @@ -5,6 +5,7 @@ > > #include "parse-options.h" > > #include "run-command.h" > > #include "utf8.h" > > +#include "pager.c" > > Should this be pager.h? > >

Re: [PATCH v2] column: show auto columns when pager is active

2017-10-23 Thread Jonathan Nieder
Junio C Hamano wrote: > Subject: column: do not include pager.c > > Everything this file needs from the pager API (e.g. term_columns(), > pager_in_use()) is already declared in the header file it includes. > > Noticed-by: Jonathan Nieder > Signed-off-by: Junio C Hamano > --- > column.c | 1 - >

Re: [PATCH v2] column: show auto columns when pager is active

2017-10-23 Thread Junio C Hamano
Jonathan Nieder writes: > Hi, > > Kevin Daudt wrote: > >> --- a/column.c >> +++ b/column.c >> @@ -5,6 +5,7 @@ >> #include "parse-options.h" >> #include "run-command.h" >> #include "utf8.h" >> +#include "pager.c" > > Should this be pager.h? Ouch. And I was not paying enough attention. Thanks

Re: [PATCH v2] column: show auto columns when pager is active

2017-10-23 Thread Jonathan Nieder
Hi, Kevin Daudt wrote: > --- a/column.c > +++ b/column.c > @@ -5,6 +5,7 @@ > #include "parse-options.h" > #include "run-command.h" > #include "utf8.h" > +#include "pager.c" Should this be pager.h? Thanks, Jonathan

Re: [PATCH v2] column: show auto columns when pager is active

2017-10-16 Thread Junio C Hamano
Kevin Daudt writes: > When columns are set to automatic for git tag and the output is > paginated by git, the output is a single column instead of multiple > columns. > > Standard behaviour in git is to honor auto values when the pager is > active, which happens for example with commands like git

[PATCH v2] column: show auto columns when pager is active

2017-10-16 Thread Kevin Daudt
When columns are set to automatic for git tag and the output is paginated by git, the output is a single column instead of multiple columns. Standard behaviour in git is to honor auto values when the pager is active, which happens for example with commands like git log showing colors when being pa