Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2017-05-09 Thread Jeff King
On Tue, May 02, 2017 at 03:22:23PM +0200, Ævar Arnfjörð Bjarmason wrote: > Is there any way with this to both supply CFLAGS & DEVELOPER=1 on the > command-line, to get my custom -O & these -W flags? I.e.: > > $ make DEVELOPER=1 V=1 > [...] -g -O2 -Wall -Werror -Wdeclaration-after-statement > -Wno

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2017-05-02 Thread Ævar Arnfjörð Bjarmason
On Thu, Feb 25, 2016 at 9:42 AM, wrote: > From: Lars Schneider > > We assume Git developers have a reasonably modern compiler and recommend > them to enable the DEVELOPER makefile knob to ensure their patches are > clear of all compiler warnings the Git core project cares about. > > Enable the D

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-28 Thread Duy Nguyen
On Sun, Feb 28, 2016 at 5:35 PM, Lars Schneider wrote: > On 26 Feb 2016, at 10:33, Duy Nguyen wrote: >> Probably misunderstanding. I meant something like this >> >> CFLAGS += -Werror >> CFLAGS += -Wdecl.. >> CFLAGS += -Wno-form.. > > Oh. I just realized the patch made it already into master. Do y

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-28 Thread Lars Schneider
On 26 Feb 2016, at 10:33, Duy Nguyen wrote: > On Fri, Feb 26, 2016 at 4:30 PM, Lars Schneider > wrote: >> >>> On 26 Feb 2016, at 10:26, Duy Nguyen wrote: >>> >>> On Thu, Feb 25, 2016 at 3:42 PM, wrote: +ifdef DEVELOPER + CFLAGS += -Werror \ +

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-26 Thread Duy Nguyen
On Fri, Feb 26, 2016 at 4:30 PM, Lars Schneider wrote: > >> On 26 Feb 2016, at 10:26, Duy Nguyen wrote: >> >> On Thu, Feb 25, 2016 at 3:42 PM, wrote: >>> +ifdef DEVELOPER >>> + CFLAGS += -Werror \ >>> + -Wdeclaration-after-statement \ >>> +

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-26 Thread Lars Schneider
> On 26 Feb 2016, at 10:26, Duy Nguyen wrote: > > On Thu, Feb 25, 2016 at 3:42 PM, wrote: >> +ifdef DEVELOPER >> + CFLAGS += -Werror \ >> + -Wdeclaration-after-statement \ >> + -Wno-format-zero-length \ >> +

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-26 Thread Lars Schneider
Thanks for the reviews and the fix :-) Any thought on the "-Wold-style-declaration" problem mentioned in my first v2 email? - Lars > On 25 Feb 2016, at 18:40, Junio C Hamano wrote: > > Perhaps squash these two while queuing to address comments from you two? > > Thanks. > > Documentation/Cod

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-26 Thread Duy Nguyen
On Thu, Feb 25, 2016 at 3:42 PM, wrote: > +ifdef DEVELOPER > + CFLAGS += -Werror \ > + -Wdeclaration-after-statement \ > + -Wno-format-zero-length \ > + -Wold-style-definition \ > +

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-25 Thread Junio C Hamano
Perhaps squash these two while queuing to address comments from you two? Thanks. Documentation/CodingGuidelines | 3 ++- Makefile | 18 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/Documentation/CodingGuidelines b/Documentation/Coding

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-25 Thread Michael Haggerty
On 02/25/2016 09:42 AM, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > We assume Git developers have a reasonably modern compiler and recommend > them to enable the DEVELOPER makefile knob to ensure their patches are > clear of all compiler warnings the Git core project cares about. >

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-25 Thread Matthieu Moy
larsxschnei...@gmail.com writes: > --- a/Makefile > +++ b/Makefile > @@ -380,6 +380,18 @@ ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS) > ALL_LDFLAGS = $(LDFLAGS) > STRIP ?= strip > > +ifdef DEVELOPER > + CFLAGS += -Werror \ > + -Wdeclaration-after-statement \ > +

[PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

2016-02-25 Thread larsxschneider
From: Lars Schneider We assume Git developers have a reasonably modern compiler and recommend them to enable the DEVELOPER makefile knob to ensure their patches are clear of all compiler warnings the Git core project cares about. Enable the DEVELOPER makefile knob in the Travis-CI build. Sugges