Re: [PATCH v2] Revert "graph.c: mark private file-scope symbols as static"

2013-03-03 Thread Jason A. Donenfeld
On Sun, Mar 3, 2013 at 10:42 PM, Junio C Hamano wrote: > I suspect that many people outside CGit circle may not know who this > Jason > That active contributor is Jason. The repository has also been moved > to Jason's http://git.zx2c4.com/cgit/ > So, thanks, Jason and John for your efforts. Hey f

Re: [PATCH v2] Revert "graph.c: mark private file-scope symbols as static"

2013-03-03 Thread Junio C Hamano
"Jason A. Donenfeld" writes: > Signed-off-by: Jason A. Donenfeld I suspect that many people outside CGit circle may not know who this Jason (who never appeared in git@vger.kernel.org) is, and are wondering in what capacity he is sending a S-o-b for somebody else's patch without explanation. An

Re: [PATCH v2] Revert "graph.c: mark private file-scope symbols as static"

2013-03-03 Thread Johan Herland
On Mon, Mar 4, 2013 at 1:03 AM, John Keeping wrote: > This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. > > CGit uses these symbols to output the correct HTML around graph > elements. Making these symbols private means that CGit cannot be > updated to use Git 1.8.0 or newer, so let's

Re: [PATCH v2] Revert "graph.c: mark private file-scope symbols as static"

2013-03-03 Thread Jason A. Donenfeld
Signed-off-by: Jason A. Donenfeld On Sun, Mar 3, 2013 at 7:03 PM, John Keeping wrote: > This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. > > CGit uses these symbols to output the correct HTML around graph > elements. Making these symbols private means that CGit cannot be > updated

[PATCH v2] Revert "graph.c: mark private file-scope symbols as static"

2013-03-03 Thread John Keeping
This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses these symbols to output the correct HTML around graph elements. Making these symbols private means that CGit cannot be updated to use Git 1.8.0 or newer, so let's not do that. On top of the revert, also add comments so that