Re: [PATCH v2] Place cache.h at the first place to match general rule

2014-03-02 12:34 GMT+08:00 Eric Sunshine : > On Sat, Mar 1, 2014 at 9:18 PM, Sun He wrote: >> Signed-off-by: Sun He >> Helped-by: Duy Nguyen > > Footers should follow a temporal order. For instance: > > 1. Duy helped you. > 2. You revised your patch based upon his input. > 3. You signed off befo

Re: [PATCH v2] Place cache.h at the first place to match general rule

On Sat, Mar 1, 2014 at 9:18 PM, Sun He wrote: > Signed-off-by: Sun He > Helped-by: Duy Nguyen Footers should follow a temporal order. For instance: 1. Duy helped you. 2. You revised your patch based upon his input. 3. You signed off before submitting the patch. Hence, your Signed-off-by: shou

[PATCH v2] Place cache.h at the first place to match general rule

Signed-off-by: Sun He Helped-by: Duy Nguyen --- "PATCH v2" Fix the spelling bug of general in subject as is suggested by brain m.calson The general rule is if cache.h or git-compat-util.h is included, it is the first #include. I parsed all the source files, and find many files start with