Re: [PATCH v2] Let submodule command exit with error status if path does not exist

Heiko Voigt writes: > How about I update CodingGuidelines according to the rules you > suggested? Then other people know how we prefer bash functions and if > statements to look like. OK. I was hoping that "imitate surrounding code" was sufficient, but it seems many parts of the codebase have d

Re: [PATCH v2] Let submodule command exit with error status if path does not exist

Hi Junio, thanks for such a thorough review. On Sat, Aug 11, 2012 at 10:43:22PM -0700, Junio C Hamano wrote: > Heiko Voigt writes: > > > I did not know that you prefer a space after the function name. I simply > > imitated the style from C and there we do not have spaces. It makes the > > style

Re: [PATCH v2] Let submodule command exit with error status if path does not exist

Heiko Voigt writes: > I did not know that you prefer a space after the function name. I simply > imitated the style from C and there we do not have spaces. It makes the > style rules a bit more complicated. Wouldn't it be nicer to have the > same as in C so we have less rules? I do not think so,

[PATCH v2] Let submodule command exit with error status if path does not exist

Previously the exit status of git submodule was zero for various subcommands even though the user specified an unknown path. The reason behind that was that they all pipe the output of module_list into the while loop which then does the action on the paths specified by the commandline. Since the e