Re: [PATCH v18 10/48] refs.c: verify_lock should set errno to something meaningful

2014-06-18 Thread Ronnie Sahlberg
fixed in 19 On Wed, Jun 18, 2014 at 1:38 PM, Michael Haggerty wrote: > On 06/17/2014 05:53 PM, Ronnie Sahlberg wrote: >> Making errno when returning from verify_lock() meaningful, which >> should almost but not completely fix >> >> * a bug in "git fetch"'s s_update_ref, which trusts the result o

Re: [PATCH v18 10/48] refs.c: verify_lock should set errno to something meaningful

2014-06-18 Thread Michael Haggerty
On 06/17/2014 05:53 PM, Ronnie Sahlberg wrote: > Making errno when returning from verify_lock() meaningful, which > should almost but not completely fix > > * a bug in "git fetch"'s s_update_ref, which trusts the result of an >errno == ENOTDIR check to detect D/F conflicts > > ENOTDIR makes

[PATCH v18 10/48] refs.c: verify_lock should set errno to something meaningful

2014-06-17 Thread Ronnie Sahlberg
Making errno when returning from verify_lock() meaningful, which should almost but not completely fix * a bug in "git fetch"'s s_update_ref, which trusts the result of an errno == ENOTDIR check to detect D/F conflicts ENOTDIR makes sense as a sign that a file was in the way of a directory we