Re: [PATCH v17 16/48] refs.c: add an err argument to delete_ref_loose

2014-06-17 Thread Junio C Hamano
Ronnie Sahlberg writes: > Thanks. > > I have rebased it on current master and re-sent it as v18 > > I passes all tests, except t0008 which is unrelated to this series. I think You need to either have 97c1364b (t0008: do not depend on 'echo' handling backslashes specially, 2014-06-13), or avoid u

Re: [PATCH v17 16/48] refs.c: add an err argument to delete_ref_loose

2014-06-17 Thread Ronnie Sahlberg
Thanks. I have rebased it on current master and re-sent it as v18 I passes all tests, except t0008 which is unrelated to this series. regards ronnie sahlberg On Tue, Jun 17, 2014 at 7:34 AM, Ronnie Sahlberg wrote: > Let me redo it so it applies to current master. > > On Mon, Jun 16, 2014 at 5

Re: [PATCH v17 16/48] refs.c: add an err argument to delete_ref_loose

2014-06-17 Thread Ronnie Sahlberg
Let me redo it so it applies to current master. On Mon, Jun 16, 2014 at 5:22 PM, Junio C Hamano wrote: > The series applies cleanly up to 25/48 or so to 'master', but this > step already breaks tests, at least t1400 but possibly others. > > Please do not make me bisect X-<. > > Thanks. -- To unsu

Re: [PATCH v17 16/48] refs.c: add an err argument to delete_ref_loose

2014-06-16 Thread Junio C Hamano
The series applies cleanly up to 25/48 or so to 'master', but this step already breaks tests, at least t1400 but possibly others. Please do not make me bisect X-<. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More

[PATCH v17 16/48] refs.c: add an err argument to delete_ref_loose

2014-06-16 Thread Ronnie Sahlberg
Add an err argument to delete_loose_ref so that we can pass a descriptive error string back to the caller. Pass the err argument from transaction commit to this function so that transaction users will have a nice error string if the transaction failed due to delete_loose_ref. Add a new function un