Re: [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C

2017-11-07 Thread Ramsay Jones
On 27/10/17 16:06, Pranit Bauva wrote: > Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` > subcommand to `git bisect--helper` to call it from git-bisect.sh . > > Using `bisect_reset` subcommand is a temporary measure to port shell > functions to C so as to use the exist

Re: [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C

2017-10-30 Thread Pranit Bauva
Hey Stephan, On Mon, Oct 30, 2017 at 6:52 PM, Stephan Beyer wrote: > Hi Pranit, >> +static int bisect_reset(const char *commit) >> +{ >> + struct strbuf branch = STRBUF_INIT; >> + >> + if (!commit) { >> + if (strbuf_read_file(&branch, git_path_bisect_start(), 0) < 1) >> +

Re: [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C

2017-10-30 Thread Pranit Bauva
Hey Junio, On Fri, Oct 27, 2017 at 11:10 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +static int bisect_reset(const char *commit) >> +{ >> + struct strbuf branch = STRBUF_INIT; >> + >> + if (!commit) { >> + if (strbuf_read_file(&branch, git_path_bisect_start(), 0) <

Re: [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C

2017-10-30 Thread Stephan Beyer
Hi Pranit, On 10/27/2017 05:06 PM, Pranit Bauva wrote: > A big thanks to Stephan and Ramsay for patiently reviewing my series and > helping me get this merged. You're welcome. ;) In addition to the things mentioned by the other reviewers, only a minor thing: > diff --git a/builtin/bisect--helpe

Re: [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C

2017-10-27 Thread Junio C Hamano
Pranit Bauva writes: > +static int bisect_reset(const char *commit) > +{ > + struct strbuf branch = STRBUF_INIT; > + > + if (!commit) { > + if (strbuf_read_file(&branch, git_path_bisect_start(), 0) < 1) > + return !printf(_("We are not bisecting.\n")); > +

Re: [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C

2017-10-27 Thread Pranit Bauva
Hey, I forgot to mention. One can find the travis build here[1] which is passing. [1]: https://travis-ci.org/git/git/builds/293725346 Regards, Pranit Bauva

[PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C

2017-10-27 Thread Pranit Bauva
Reimplement `bisect_reset` shell function in C and add a `--bisect-reset` subcommand to `git bisect--helper` to call it from git-bisect.sh . Using `bisect_reset` subcommand is a temporary measure to port shell functions to C so as to use the existing test suite. As more functions are ported, this