Re: [PATCH v16 7/7] commit: add a commit.verbose config variable

On Fri, May 6, 2016 at 10:35 AM, Pranit Bauva wrote: > I checked out your branch gitster/pb/commit-verbose-config and tests > from t0040 seem to be failing. Don't worry I will handle those, I will > squash your patch in mine and re-roll it again. I am still unsure how > those tests broke. I will

Re: [PATCH v16 7/7] commit: add a commit.verbose config variable

On Thu, May 5, 2016 at 3:14 PM, Junio C Hamano wrote: > Pranit Bauva writes: >> +static int config_verbose = -1; /* unspecified */ > > The name does not make it clear that config_verbose is only for > "commit" and not relevant to "status". > >> @@ -1364,6 +1366,8 @@ int cmd_status(int argc, const

Re: [PATCH v16 7/7] commit: add a commit.verbose config variable

On Fri, May 6, 2016 at 12:44 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> diff --git a/builtin/commit.c b/builtin/commit.c >> index 391126e..114ffc9 100644 >> --- a/builtin/commit.c >> +++ b/builtin/commit.c >> @@ -113,7 +113,9 @@ static char *edit_message, *use_message; >> static char

Re: [PATCH v16 7/7] commit: add a commit.verbose config variable

Pranit Bauva writes: > diff --git a/builtin/commit.c b/builtin/commit.c > index 391126e..114ffc9 100644 > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -113,7 +113,9 @@ static char *edit_message, *use_message; > static char *fixup_message, *squash_message; > static int all, also, interac

[PATCH v16 7/7] commit: add a commit.verbose config variable

Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Add tests to check the behavior introduced by this commit and also to verify that behavior of status doesn't break because of this commit. Helped-by: Junio C Hamano Helped-by: Eric Sunshine Signed-