Re: [PATCH v15 09/27] bisect--helper: `bisect_write` shell function in C

2016-12-06 Thread Pranit Bauva
Hey Stephan, On Thu, Nov 17, 2016 at 3:10 PM, Stephan Beyer wrote: > Hi, > > I've only got some minors to mention here ;) > > On 10/14/2016 04:14 PM, Pranit Bauva wrote: >> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c >> index c542e8b..3f19b68 100644 >> --- a/builtin/bisect--h

Re: [PATCH v15 09/27] bisect--helper: `bisect_write` shell function in C

2016-11-17 Thread Stephan Beyer
Hi, I've only got some minors to mention here ;) On 10/14/2016 04:14 PM, Pranit Bauva wrote: > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index c542e8b..3f19b68 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > @@ -19,9 +19,15 @@ static const char

[PATCH v15 09/27] bisect--helper: `bisect_write` shell function in C

2016-10-14 Thread Pranit Bauva
Reimplement the `bisect_write` shell function in C and add a `bisect-write` subcommand to `git bisect--helper` to call it from git-bisect.sh Using `--bisect-write` subcommand is a temporary measure to port shell function in C so as to use the existing test suite. As more functions are ported, this