Re: [PATCH v15 04/16] Refactor quote_path_relative, remove unused params

2013-06-26 Thread Jiang Xin
2013/6/27 Junio C Hamano : >> diff --git a/quote.c b/quote.c >> index 64ff3..ebb8 100644 > > You seem to be using unusually short abbrev length. > > Please don't, at least in format-patch output. > > "ebb8" may be unique within your repository, but may not be unique > in repositories of other peopl

Re: [PATCH v15 04/16] Refactor quote_path_relative, remove unused params

2013-06-26 Thread Junio C Hamano
Jiang Xin writes: > After substitute path_relative() in quote.c with relative_path() from > path.c, parameters (such as len and prefix_len) are obsolete in function > quote_path_relative(). Remove unused parameters and change the order of > parameters for quote_path_relative() function. > > Signe

[PATCH v15 04/16] Refactor quote_path_relative, remove unused params

2013-06-25 Thread Jiang Xin
After substitute path_relative() in quote.c with relative_path() from path.c, parameters (such as len and prefix_len) are obsolete in function quote_path_relative(). Remove unused parameters and change the order of parameters for quote_path_relative() function. Signed-off-by: Jiang Xin Signed-off