Re: [PATCH v12 5/5] commit: add a commit.verbose config variable

2016-04-05 Thread Pranit Bauva
On Tue, Apr 5, 2016 at 4:59 AM, Eric Sunshine wrote: > On Sun, Apr 3, 2016 at 8:58 PM, Eric Sunshine wrote: >> The fact that the 32 new tests are nearly identical suggests strongly >> that the testing should instead either be table-driven or be done via >> for-loops to systematically cover all ca

Re: [PATCH v12 5/5] commit: add a commit.verbose config variable

2016-04-04 Thread Eric Sunshine
On Sun, Apr 3, 2016 at 8:58 PM, Eric Sunshine wrote: > The fact that the 32 new tests are nearly identical suggests strongly > that the testing should instead either be table-driven or be done via > for-loops to systematically cover all cases. Not only would either of > these approaches be easier

Re: [PATCH v12 5/5] commit: add a commit.verbose config variable

2016-04-03 Thread Eric Sunshine
On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva wrote: > Add commit.verbose configuration variable as a convenience for those > who always prefer --verbose. > > Signed-off-by: Pranit Bauva > --- > diff --git a/Documentation/config.txt b/Documentation/config.txt > @@ -1110,6 +1110,10 @@ commit.templa

[PATCH v12 5/5] commit: add a commit.verbose config variable

2016-04-02 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano Helped-by: Eric Sunshine Signed-off-by: Pranit Bauva --- The previous version of the patch are: - [v11] $gmane/288820 - [v10] $gmane/288820 - [v9] $gmane/288820 - [v8