Re: [PATCH v12 1/5] t0040-test-parse-options.sh: fix style issues

2016-04-04 Thread Pranit Bauva
On Mon, Apr 4, 2016 at 11:00 PM, Eric Sunshine wrote: > On Mon, Apr 4, 2016 at 8:45 AM, Pranit Bauva wrote: >> Okay I will do the change. I was previously unaware about the use of >> '\' before EOF. I googled it now. But I am still confused about its >> use in this scenario. Upto what I understoo

Re: [PATCH v12 1/5] t0040-test-parse-options.sh: fix style issues

2016-04-04 Thread Eric Sunshine
On Mon, Apr 4, 2016 at 8:45 AM, Pranit Bauva wrote: > Okay I will do the change. I was previously unaware about the use of > '\' before EOF. I googled it now. But I am still confused about its > use in this scenario. Upto what I understood, it is used where you > want to expand a variable, substit

Re: [PATCH v12 1/5] t0040-test-parse-options.sh: fix style issues

2016-04-04 Thread Pranit Bauva
On Mon, Apr 4, 2016 at 2:30 AM, Eric Sunshine wrote: > On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva wrote: >> Signed-off-by: Pranit Bauva >> --- >> diff --git a/t/t0040-parse-options.sh b/t/t0040-parse-options.sh >> @@ -7,7 +7,7 @@ test_description='our own option parser' >> >> . ./test-lib.sh

Re: [PATCH v12 1/5] t0040-test-parse-options.sh: fix style issues

2016-04-03 Thread Eric Sunshine
On Sat, Apr 2, 2016 at 7:33 PM, Pranit Bauva wrote: > Signed-off-by: Pranit Bauva > --- > diff --git a/t/t0040-parse-options.sh b/t/t0040-parse-options.sh > @@ -7,7 +7,7 @@ test_description='our own option parser' > > . ./test-lib.sh > > -cat > expect << EOF > +cat >expect < usage: test-parse-o

[PATCH v12 1/5] t0040-test-parse-options.sh: fix style issues

2016-04-02 Thread Pranit Bauva
Signed-off-by: Pranit Bauva --- Changes wrt previous version (v11): - This patch is a split up of patch 1/4 v11 as requested by Junio. - This patch uses the backslash with EOF as suggested by Junio for 2 tests namely "detect possible typos" --- t/t0040-parse-options.sh | 72