Re: [PATCH v1 1/6] Allow --porcelain[=] in status and commit commands

2016-07-21 Thread Johannes Schindelin
Hi Jeff, On Wed, 20 Jul 2016, Jeff Hostetler wrote: > On 07/20/2016 11:08 AM, Johannes Schindelin wrote: > > On Tue, 19 Jul 2016, Jeff Hostetler wrote: > > > @@ -1336,9 +1347,9 @@ int cmd_status(int argc, const char **argv, const > > > char *prefix) > > > N_("show status concisely")

Re: [PATCH v1 1/6] Allow --porcelain[=] in status and commit commands

2016-07-20 Thread Junio C Hamano
Jeff Hostetler writes: > diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt > index b0a294d..0791573 100644 > --- a/Documentation/git-commit.txt > +++ b/Documentation/git-commit.txt > @@ -104,7 +104,7 @@ OPTIONS > --branch:: > Show the branch and tracking info even in

Re: [PATCH v1 1/6] Allow --porcelain[=] in status and commit commands

2016-07-20 Thread Jeff Hostetler
On 07/20/2016 11:58 AM, Jeff King wrote: On Tue, Jul 19, 2016 at 06:10:53PM -0400, Jeff Hostetler wrote: +static int opt_parse_porcelain(const struct option *opt, const char *arg, int unset) +{ + enum wt_status_format *value = (enum wt_status_format *)opt->value; + if (unset) { +

Re: [PATCH v1 1/6] Allow --porcelain[=] in status and commit commands

2016-07-20 Thread Jeff King
On Tue, Jul 19, 2016 at 06:10:53PM -0400, Jeff Hostetler wrote: > +static int opt_parse_porcelain(const struct option *opt, const char *arg, > int unset) > +{ > + enum wt_status_format *value = (enum wt_status_format *)opt->value; > + if (unset) { > + *value = STATUS_FORMAT_UN

Re: [PATCH v1 1/6] Allow --porcelain[=] in status and commit commands

2016-07-20 Thread Jeff Hostetler
On 07/20/2016 11:08 AM, Johannes Schindelin wrote: On Tue, 19 Jul 2016, Jeff Hostetler wrote: diff --git a/builtin/commit.c b/builtin/commit.c + } else if (arg) { + int n = strtol(arg, NULL, 10); + if (n == 1) + *value = STATUS_FORMAT_POR

Re: [PATCH v1 1/6] Allow --porcelain[=] in status and commit commands

2016-07-20 Thread Johannes Schindelin
Hi Jeff, On Tue, 19 Jul 2016, Jeff Hostetler wrote: > Update the --porcelain argument to take an optional > version number. This will allow us to define new > porcelain formats in the future. > > This default to 1 and represents the existing porcelain > format. > > Signed-off-by: Jeff Hostetle

[PATCH v1 1/6] Allow --porcelain[=] in status and commit commands

2016-07-19 Thread Jeff Hostetler
Update the --porcelain argument to take an optional version number. This will allow us to define new porcelain formats in the future. This default to 1 and represents the existing porcelain format. Signed-off-by: Jeff Hostetler --- Documentation/git-commit.txt | 2 +- Documentation/git-status