Re: [PATCH v1 1/2] t0027: Correct raciness in NNO test

2016-08-14 Thread Junio C Hamano
Torsten Bögershausen writes: > Looking at t0027, it turns out that the changes in the test matrix done in 1/2 > are reverted in 2/2. > This is not a good thing. > Either (a) they should be marked as test_expect_failure in 1/2 and > corrected in 2/2, > or (b) 1/2 and 2/2 are squashed together and

Re: [PATCH v1 1/2] t0027: Correct raciness in NNO test

2016-08-14 Thread Torsten Bögershausen
On Sat, Aug 13, 2016 at 06:50:19PM +0200, Johannes Sixt wrote: > Am 12.08.2016 um 18:51 schrieb tbo...@web.de: > >From: Torsten Bögershausen > > > >When a non-reversible CRLF conversion is done in "git add", > >a warning is printed on stderr (or Git dies, depending on checksafe) > > > >The functio

Re: [PATCH v1 1/2] t0027: Correct raciness in NNO test

2016-08-13 Thread Johannes Sixt
Am 12.08.2016 um 18:51 schrieb tbo...@web.de: From: Torsten Bögershausen When a non-reversible CRLF conversion is done in "git add", a warning is printed on stderr (or Git dies, depending on checksafe) The function commit_chk_wrnNNO() in t0027 was written to test this, but did the wrong thing:

Re: [PATCH v1 1/2] t0027: Correct raciness in NNO test

2016-08-12 Thread Junio C Hamano
tbo...@web.de writes: > From: Torsten Bögershausen > > When a non-reversible CRLF conversion is done in "git add", > a warning is printed on stderr (or Git dies, depending on checksafe) > > The function commit_chk_wrnNNO() in t0027 was written to test this, > but did the wrong thing: Instead of l

[PATCH v1 1/2] t0027: Correct raciness in NNO test

2016-08-12 Thread tboegi
From: Torsten Bögershausen When a non-reversible CRLF conversion is done in "git add", a warning is printed on stderr (or Git dies, depending on checksafe) The function commit_chk_wrnNNO() in t0027 was written to test this, but did the wrong thing: Instead of looking at the warning from "git add