Re: [PATCH v1 09/19] config: add git_config_get_max_percent_split_change()

2016-11-04 Thread Christian Couder
On Tue, Nov 1, 2016 at 8:13 PM, Junio C Hamano wrote: > >>> + return -1; > > Perhaps do the usual > > return error(_("...")); > > here? Ok, it will be in the next version.

Re: [PATCH v1 09/19] config: add git_config_get_max_percent_split_change()

2016-11-01 Thread Junio C Hamano
Duy Nguyen writes: > On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder > wrote: >> This new function will be used in a following commit to get the >> +int git_config_get_max_percent_split_change(void) >> +{ >> + int val = -1; >> + >> + if (!git_config_get_int("splitindex.maxpercentch

Re: [PATCH v1 09/19] config: add git_config_get_max_percent_split_change()

2016-10-29 Thread Christian Couder
On Tue, Oct 25, 2016 at 12:06 PM, Duy Nguyen wrote: > On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder > wrote: >> This new function will be used in a following commit to get the >> +int git_config_get_max_percent_split_change(void) >> +{ >> + int val = -1; >> + >> + if (!git_config_

Re: [PATCH v1 09/19] config: add git_config_get_max_percent_split_change()

2016-10-25 Thread Duy Nguyen
On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder wrote: > This new function will be used in a following commit to get the > +int git_config_get_max_percent_split_change(void) > +{ > + int val = -1; > + > + if (!git_config_get_int("splitindex.maxpercentchange", &val)) { > +

[PATCH v1 09/19] config: add git_config_get_max_percent_split_change()

2016-10-23 Thread Christian Couder
This new function will be used in a following commit to get the value of the "splitIndex.maxPercentChange" config variable. Signed-off-by: Christian Couder --- cache.h | 1 + config.c | 16 2 files changed, 17 insertions(+) diff --git a/cache.h b/cache.h index 394da60..facece