Re: [PATCH v1 08/19] rebase -i: root commits are replayed with an unnecessary option

2014-08-04 Thread Fabian Ruch
Hi Jeff, Jeff King writes: > On Tue, Jul 29, 2014 at 01:18:08AM +0200, Fabian Ruch wrote: >> The command line used to recreate root commits specifies the >> effectless option `-C`. It makes git-commit reuse commit message and >> authorship of the named commit. However, the commit being amended >>

Re: [PATCH v1 08/19] rebase -i: root commits are replayed with an unnecessary option

2014-08-01 Thread Jeff King
On Tue, Jul 29, 2014 at 01:18:08AM +0200, Fabian Ruch wrote: > The command line used to recreate root commits specifies the > effectless option `-C`. It makes git-commit reuse commit message and > authorship of the named commit. However, the commit being amended > here, which is the sentinel commi

[PATCH v1 08/19] rebase -i: root commits are replayed with an unnecessary option

2014-07-28 Thread Fabian Ruch
The command line used to recreate root commits specifies the effectless option `-C`. It makes git-commit reuse commit message and authorship of the named commit. However, the commit being amended here, which is the sentinel commit, already carries the authorship and log message of the commit being