Re: [PATCH v1 03/19] rebase -i: reword executes pre-commit hook on interim commit

2014-08-06 Thread Jeff King
On Mon, Aug 04, 2014 at 08:51:42PM +0200, Fabian Ruch wrote: > > though I would also not be opposed to some more uniform hook selection > > mechanism (e.g., "--no-verify=pre-commit" or something). > > While the --no-verify= mechanism doesn't add a new option to the > git-commit interface but lets

Re: [PATCH v1 03/19] rebase -i: reword executes pre-commit hook on interim commit

2014-08-04 Thread Fabian Ruch
Hi, Jeff King writes: > On Tue, Jul 29, 2014 at 01:18:03AM +0200, Fabian Ruch wrote: > >> Specify the git-commit option `--no-verify` to disable the pre-commit >> hook when editing the log message. Because `--no-verify` also skips >> the commit-msg hook, execute the hook from within >> git-rebase

Re: [PATCH v1 03/19] rebase -i: reword executes pre-commit hook on interim commit

2014-08-01 Thread Jeff King
On Tue, Jul 29, 2014 at 01:18:03AM +0200, Fabian Ruch wrote: > Specify the git-commit option `--no-verify` to disable the pre-commit > hook when editing the log message. Because `--no-verify` also skips > the commit-msg hook, execute the hook from within > git-rebase--interactive after the commit

[PATCH v1 03/19] rebase -i: reword executes pre-commit hook on interim commit

2014-07-28 Thread Fabian Ruch
The to-do list command `reword` replays a commit like `pick` but lets the user also edit the commit's log message. This happens in two steps. Firstly, the named commit is cherry-picked. Secondly, the commit created in the first step is amended using an unchanged index to edit the log message. The p