Re: [PATCH v1 0/3] Git filter protocol

2016-07-26 Thread Jeff King
On Sun, Jul 24, 2016 at 01:24:29PM +0200, Lars Schneider wrote: > What if we would keep the config option "protocol" and make it an "int"? > Undefined or version "1" would describe the existing clean/smudge > protocol via command line and pipe. Version "2" would be the new protocol? FWIW, that

Re: [PATCH v1 0/3] Git filter protocol

2016-07-24 Thread Lars Schneider
On 22 Jul 2016, at 23:39, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> The first two patches are cleanup patches which are not really necessary >> for the feature. > > These two looked trivially good. Thanks! > I think I can agree with what 3/3 wants to do in principle, but

Re: [PATCH v1 0/3] Git filter protocol

2016-07-22 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > The first two patches are cleanup patches which are not really necessary > for the feature. These two looked trivially good. I think I can agree with what 3/3 wants to do in principle, but * "protocol" is not quite the right word. The current way to inter

[PATCH v1 0/3] Git filter protocol

2016-07-22 Thread larsxschneider
From: Lars Schneider Hi, Git's clean/smudge mechanism invokes an external filter process for every single blob that is affected by a filter. If Git filters a lot of blobs then the startup time of the external filter processes can become a significant part of the overall Git execution time. This