Re: [PATCH v1] perf/aggregate: tighten option parsing

2018-04-25 Thread Christian Couder
On Sat, Apr 21, 2018 at 5:50 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >>> Not necessarily worth a re-roll. >> >> Not that it matters in this case, but just as a bit of Perl rx pedantry, >> yes his is tighter & more correct. You didn't consider how "." interacts >> with newlin

Re: [PATCH v1] perf/aggregate: tighten option parsing

2018-04-20 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> Not necessarily worth a re-roll. > > Not that it matters in this case, but just as a bit of Perl rx pedantry, > yes his is tighter & more correct. You didn't consider how "." interacts > with newlines: > > $ perl -wE 'my @rx = (qr/^--./, qr/^--.+$/, qr/^--./

Re: [PATCH v1] perf/aggregate: tighten option parsing

2018-04-20 Thread Ævar Arnfjörð Bjarmason
On Fri, Apr 20 2018, Eric Sunshine wrote: > On Fri, Apr 20, 2018 at 8:10 AM, Christian Couder > wrote: >> When passing an option '--foo' that it does not recognize, the >> aggregate.perl script should die with an helpful error message >> like: >> >> unknown option '--foo' at ./aggregate.perl l

Re: [PATCH v1] perf/aggregate: tighten option parsing

2018-04-20 Thread Eric Sunshine
On Fri, Apr 20, 2018 at 8:10 AM, Christian Couder wrote: > When passing an option '--foo' that it does not recognize, the > aggregate.perl script should die with an helpful error message > like: > > unknown option '--foo' at ./aggregate.perl line 80. > > rather than: > > fatal: Needed a single

[PATCH v1] perf/aggregate: tighten option parsing

2018-04-20 Thread Christian Couder
When passing an option '--foo' that it does not recognize, the aggregate.perl script should die with an helpful error message like: unknown option '--foo' at ./aggregate.perl line 80. rather than: fatal: Needed a single revision rev-parse --verify --foo: command returned error: 128 While