Re: [PATCH V3 2/5] Help.c use OPT_BOOL and refactor logic

2013-04-03 Thread Philip Oakley
Sent: Wednesday, April 03, 2013 2:13 AM Junio C Hamano writes: You are creating a gap in the output so that you can add some more stuff in later patches, which is fine, but I do not think we call that kind of change a "refactor" ;-). The change looks fine. I'll queue what I suggested on 'pu

Re: [PATCH V3 2/5] Help.c use OPT_BOOL and refactor logic

2013-04-02 Thread Junio C Hamano
Junio C Hamano writes: > You are creating a gap in the output so that you can add some more > stuff in later patches, which is fine, but I do not think we call > that kind of change a "refactor" ;-). > > The change looks fine. I'll queue what I suggested on 'pu' for now. Thanks. -- To unsubscri

Re: [PATCH V3 2/5] Help.c use OPT_BOOL and refactor logic

2013-04-02 Thread Junio C Hamano
Philip Oakley writes: > Rename deprecated OPT_BOOLEAN option to OPT_BOOL in preparation for > 'git help --guides'. The former OPT_BOOLEAN would now be OPT_COUNTUP, > but that capability is not required. > > Separate out the show_all 'return(0)' and git_more_info_string logic > ready for inclusion

[PATCH V3 2/5] Help.c use OPT_BOOL and refactor logic

2013-04-02 Thread Philip Oakley
Rename deprecated OPT_BOOLEAN option to OPT_BOOL in preparation for 'git help --guides'. The former OPT_BOOLEAN would now be OPT_COUNTUP, but that capability is not required. Separate out the show_all 'return(0)' and git_more_info_string logic ready for inclusion of show_guides. Signed-off-by: Ph