Re: [PATCH V2] commit.c: Use skip_prefix() instead of starts_with()

2014-03-03 Thread Junio C Hamano
Max Horn writes: > On 03.03.2014, at 20:43, Junio C Hamano wrote: > >> Tanay Abhra writes: >> >>> @@ -1193,9 +1194,9 @@ static void parse_gpg_output(struct signature_check >>> *sigc) >>> for (i = 0; i < ARRAY_SIZE(sigcheck_gpg_status); i++) { >>> const char *found, *next; >>>

Re: [PATCH V2] commit.c: Use skip_prefix() instead of starts_with()

2014-03-03 Thread Max Horn
On 03.03.2014, at 20:43, Junio C Hamano wrote: > Tanay Abhra writes: > >> @@ -1193,9 +1194,9 @@ static void parse_gpg_output(struct signature_check >> *sigc) >> for (i = 0; i < ARRAY_SIZE(sigcheck_gpg_status); i++) { >> const char *found, *next; >> >> -if (start

Re: [PATCH V2] commit.c: Use skip_prefix() instead of starts_with()

2014-03-03 Thread Junio C Hamano
Tanay Abhra writes: > In record_author_date() & parse_gpg_output() ,using skip_prefix() instead of > starts_with() is more elegant and abstracts away the details. Avoid subjective judgement like "more elegant" when justifying your change; you are not your own judge. The caller of starts_with()

[PATCH V2] commit.c: Use skip_prefix() instead of starts_with()

2014-03-03 Thread Tanay Abhra
In record_author_date() & parse_gpg_output() ,using skip_prefix() instead of starts_with() is more elegant and abstracts away the details. Helped-by: Michael Haggerty Signed-off-by: Tanay Abhra --- Patch V2 Corrected email formatting ,reapplied the implementation according to suggestions.