Re: [PATCH RFC v2 08/19] rebase -i: Root commits are replayed with an unnecessary option

Hi Junio, Junio C Hamano writes: > Fabian Ruch writes: >> It makes the next patch easier to understand because the finalising >> command line "git commit --allow-empty --amend --no-post-rewrite -n >> --no-edit" seems to be simply moved to the end of do_pick. Substituting >> --no-edit for -C there

Re: [PATCH RFC v2 08/19] rebase -i: Root commits are replayed with an unnecessary option

Fabian Ruch writes: > It makes the next patch easier to understand because the finalising > command line "git commit --allow-empty --amend --no-post-rewrite -n > --no-edit" seems to be simply moved to the end of do_pick. Substituting > --no-edit for -C there would make that log message overly lon

Re: [PATCH RFC v2 08/19] rebase -i: Root commits are replayed with an unnecessary option

Hi Junio, Junio C Hamano writes: > Fabian Ruch writes: >> The command line used to recreate root commits specifies the >> effectless option `-C`. It is used to reuse commit message and >> authorship from the named commit but the commit being amended here, >> which is the sentinel commit, already

Re: [PATCH RFC v2 08/19] rebase -i: Root commits are replayed with an unnecessary option

Fabian Ruch writes: > The command line used to recreate root commits specifies the > effectless option `-C`. It is used to reuse commit message and > authorship from the named commit but the commit being amended here, > which is the sentinel commit, already carries the authorship and log > messag

[PATCH RFC v2 08/19] rebase -i: Root commits are replayed with an unnecessary option

The command line used to recreate root commits specifies the effectless option `-C`. It is used to reuse commit message and authorship from the named commit but the commit being amended here, which is the sentinel commit, already carries the authorship and log message of the processed commit. Note