Re: [PATCH RFC 01/24] ref-filter: get rid of goto

2018-01-30 Thread Оля Тележная
2018-01-30 23:49 GMT+03:00 Junio C Hamano : > Оля Тележная writes: > >>> one place improves readability. If better readability is the >>> purpose, I would even say >>> >>> for (i = 0; i < used_atom_cnt; i++) { >>> if (...) >>> - goto need_obj; >>> +

Re: [PATCH RFC 01/24] ref-filter: get rid of goto

2018-01-30 Thread Junio C Hamano
Оля Тележная writes: >> one place improves readability. If better readability is the >> purpose, I would even say >> >> for (i = 0; i < used_atom_cnt; i++) { >> if (...) >> - goto need_obj; >> + break; >> } >> -

Re: [PATCH RFC 01/24] ref-filter: get rid of goto

2018-01-28 Thread Оля Тележная
2018-01-26 23:19 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Get rid of goto command in ref-filter for better readability. >> >> Signed-off-by: Olga Telezhnaia >> Mentored-by: Christian Couder >> Mentored by: Jeff King >> --- > > How was this patch "mentored by" these two folks?

Re: [PATCH RFC 01/24] ref-filter: get rid of goto

2018-01-26 Thread Junio C Hamano
Olga Telezhnaya writes: > Get rid of goto command in ref-filter for better readability. > > Signed-off-by: Olga Telezhnaia > Mentored-by: Christian Couder > Mentored by: Jeff King > --- How was this patch "mentored by" these two folks? Have they already reviewed and gave you OK, or are you a

[PATCH RFC 01/24] ref-filter: get rid of goto

2018-01-26 Thread Olga Telezhnaya
Get rid of goto command in ref-filter for better readability. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King --- ref-filter.c | 103 ++- 1 file changed, 53 insertions(+), 50 deletions(-) diff --git a/