Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-09 Thread Junio C Hamano
Duy Nguyen writes: > I vote one step at a time, leave multi-thread support for future. > There's a lot more shared state than file descriptors anyway, at least > there are object db and index access and probably a couple of hidden > static variables somewhere. And I'm not sure if multi-thread rea

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-09 Thread Johannes Schindelin
Hi Duy, On Sun, 8 May 2016, Duy Nguyen wrote: > On Sun, May 8, 2016 at 1:33 PM, Johannes Schindelin > wrote: > > The claim is that this libifies the procedure. But it makes the code > > really nasty for use as a library: if this is run in a thread (and you > > know that we are going to have to d

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-08 Thread Duy Nguyen
On Sun, May 8, 2016 at 1:33 PM, Johannes Schindelin wrote: > The claim is that this libifies the procedure. But it makes the code > really nasty for use as a library: if this is run in a thread (and you > know that we are going to have to do this in the near future, for > performance reasons), it

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-07 Thread Johannes Schindelin
Hi Chris, On Sat, 7 May 2016, Christian Couder wrote: > On Sat, May 7, 2016 at 2:13 PM, Johannes Schindelin > wrote: > > > > On Sat, 7 May 2016, Christian Couder wrote: > > > >> On Fri, May 6, 2016 at 5:34 PM, Johannes Schindelin > >> wrote: > >> > > >> > No, you should change the code that req

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-07 Thread Christian Couder
Hi Dscho, On Sat, May 7, 2016 at 2:13 PM, Johannes Schindelin wrote: > Hi Chris, > > On Sat, 7 May 2016, Christian Couder wrote: > >> On Fri, May 6, 2016 at 5:34 PM, Johannes Schindelin >> wrote: >> > >> > No, you should change the code that requires that ugly dup()ing so that it >> > can be con

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-07 Thread Johannes Schindelin
Hi Chris, On Sat, 7 May 2016, Christian Couder wrote: > On Fri, May 6, 2016 at 5:34 PM, Johannes Schindelin > wrote: > > > > On Fri, 6 May 2016, Christian Couder wrote: > > > >> On Thu, May 5, 2016 at 10:07 PM, Johannes Sixt wrote: > >> > Am 05.05.2016 um 11:50 schrieb Christian Couder: > >> >>

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-07 Thread Christian Couder
Hi Dscho, On Fri, May 6, 2016 at 5:34 PM, Johannes Schindelin wrote: > Hi Chris, > > On Fri, 6 May 2016, Christian Couder wrote: > >> On Thu, May 5, 2016 at 10:07 PM, Johannes Sixt wrote: >> > Am 05.05.2016 um 11:50 schrieb Christian Couder: >> >> >> >> On Mon, Apr 25, 2016 at 5:05 PM, Johannes

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-06 Thread Johannes Schindelin
Hi Chris, On Fri, 6 May 2016, Christian Couder wrote: > On Thu, May 5, 2016 at 10:07 PM, Johannes Sixt wrote: > > Am 05.05.2016 um 11:50 schrieb Christian Couder: > >> > >> On Mon, Apr 25, 2016 at 5:05 PM, Johannes Schindelin > >> wrote: > >>> > >>> Hi Chris, > >>> > >>> On Sun, 24 Apr 2016, Ch

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-06 Thread Christian Couder
On Thu, May 5, 2016 at 10:07 PM, Johannes Sixt wrote: > Am 05.05.2016 um 11:50 schrieb Christian Couder: >> >> On Mon, Apr 25, 2016 at 5:05 PM, Johannes Schindelin >> wrote: >>> >>> Hi Chris, >>> >>> On Sun, 24 Apr 2016, Christian Couder wrote: >>> diff --git a/run-command.c b/run-command.c

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-05 Thread Johannes Sixt
Am 05.05.2016 um 11:50 schrieb Christian Couder: On Mon, Apr 25, 2016 at 5:05 PM, Johannes Schindelin wrote: Hi Chris, On Sun, 24 Apr 2016, Christian Couder wrote: diff --git a/run-command.c b/run-command.c index 8c7115a..29d2bda 100644 --- a/run-command.c +++ b/run-command.c @@ -85,7 +85,7

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-05-05 Thread Christian Couder
On Mon, Apr 25, 2016 at 5:05 PM, Johannes Schindelin wrote: > Hi Chris, > > On Sun, 24 Apr 2016, Christian Couder wrote: > >> diff --git a/run-command.c b/run-command.c >> index 8c7115a..29d2bda 100644 >> --- a/run-command.c >> +++ b/run-command.c >> @@ -85,7 +85,7 @@ static inline void close_pair

Re: [PATCH 80/83] run-command: make dup_devnull() non static

2016-04-25 Thread Johannes Schindelin
Hi Chris, On Sun, 24 Apr 2016, Christian Couder wrote: > diff --git a/run-command.c b/run-command.c > index 8c7115a..29d2bda 100644 > --- a/run-command.c > +++ b/run-command.c > @@ -85,7 +85,7 @@ static inline void close_pair(int fd[2]) > } > > #ifndef GIT_WINDOWS_NATIVE > -static inline void

[PATCH 80/83] run-command: make dup_devnull() non static

2016-04-24 Thread Christian Couder
Signed-off-by: Christian Couder --- run-command.c | 2 +- run-command.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/run-command.c b/run-command.c index 8c7115a..29d2bda 100644 --- a/run-command.c +++ b/run-command.c @@ -85,7 +85,7 @@ static inline void close_pair(int