Re: [PATCH 8/8] perl: hard-depend on the File::{Temp,Spec} modules

2018-02-15 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Wed, Feb 14 2018, Jonathan Nieder jotted: > >> Ævar Arnfjörð Bjarmason wrote: >> >>> --- a/perl/Git.pm >>> +++ b/perl/Git.pm >>> @@ -1324,8 +1324,9 @@ sub _temp_cache { >>> } >>> >>> sub _verify_require { >>> - eval { require File::Temp; require File::Spec

Re: [PATCH 8/8] perl: hard-depend on the File::{Temp,Spec} modules

2018-02-15 Thread Ævar Arnfjörð Bjarmason
On Wed, Feb 14 2018, Jonathan Nieder jotted: > Ævar Arnfjörð Bjarmason wrote: > >> --- a/perl/Git.pm >> +++ b/perl/Git.pm >> @@ -1324,8 +1324,9 @@ sub _temp_cache { >> } >> >> sub _verify_require { >> -eval { require File::Temp; require File::Spec; }; >> -$@ and throw Error::Simple($@);

Re: [PATCH 8/8] perl: hard-depend on the File::{Temp,Spec} modules

2018-02-14 Thread Jonathan Nieder
Ævar Arnfjörð Bjarmason wrote: > --- a/perl/Git.pm > +++ b/perl/Git.pm > @@ -1324,8 +1324,9 @@ sub _temp_cache { > } > > sub _verify_require { > - eval { require File::Temp; require File::Spec; }; > - $@ and throw Error::Simple($@); > + require File::Temp; > + require File::Spe

[PATCH 8/8] perl: hard-depend on the File::{Temp,Spec} modules

2018-02-14 Thread Ævar Arnfjörð Bjarmason
Since my d48b284183 ("perl: bump the required Perl version to 5.8 from 5.6.[21]", 2010-09-24), we've depended on 5.8, so there's no reason to conditionally require File::Temp and File::Spec anymore. They were first released with perl versions v5.6.1 and 5.00405, respectively. This code was origina