Re: [PATCH 7/9] strbuf_getwholeline: use getdelim if it is available

2015-06-02 Thread Eric Sunshine
On Fri, May 8, 2015 at 9:09 PM, Jeff King wrote: > On Fri, May 08, 2015 at 07:56:28PM -0400, Eric Sunshine wrote: >> I spent some time downloading old Xcode releases and poking through >> the packages. Xcode 3.2.x seems to be the last in the Xcode 3 series, >> and none of the Xcode 3.2.x versions

Re: [PATCH 7/9] strbuf_getwholeline: use getdelim if it is available

2015-04-22 Thread Jeff King
On Wed, Apr 22, 2015 at 08:00:55PM +0200, Johannes Schindelin wrote: > On 2015-04-17 12:16, Eric Sunshine wrote: > > On Thu, Apr 16, 2015 at 5:01 AM, Jeff King wrote: > >> We spend a lot of time in strbuf_getwholeline in a tight > >> loop reading characters from a stdio handle into a buffer. > >>

Re: [PATCH 7/9] strbuf_getwholeline: use getdelim if it is available

2015-04-22 Thread Johannes Schindelin
Hi, On 2015-04-17 12:16, Eric Sunshine wrote: > On Thu, Apr 16, 2015 at 5:01 AM, Jeff King wrote: >> We spend a lot of time in strbuf_getwholeline in a tight >> loop reading characters from a stdio handle into a buffer. >> The libc getdelim() function can do this for us with less >> overhead. Ju

Re: [PATCH 7/9] strbuf_getwholeline: use getdelim if it is available

2015-04-21 Thread Jeff King
On Fri, Apr 17, 2015 at 06:16:48AM -0400, Eric Sunshine wrote: > > If somebody has a FreeBSD or OS X system to test on, I'd > > love to see what is needed to compile with HAVE_GETDELIM > > there. > > Modern Mac OS X, 10.10.x Yosemite, has getdelim() and git builds fine > with HAVE_GETDELIM. I als

Re: [PATCH 7/9] strbuf_getwholeline: use getdelim if it is available

2015-04-17 Thread Eric Sunshine
On Thu, Apr 16, 2015 at 5:01 AM, Jeff King wrote: > We spend a lot of time in strbuf_getwholeline in a tight > loop reading characters from a stdio handle into a buffer. > The libc getdelim() function can do this for us with less > overhead. It's in POSIX.1-2008, and was a GNU extension > before t

[PATCH 7/9] strbuf_getwholeline: use getdelim if it is available

2015-04-16 Thread Jeff King
We spend a lot of time in strbuf_getwholeline in a tight loop reading characters from a stdio handle into a buffer. The libc getdelim() function can do this for us with less overhead. It's in POSIX.1-2008, and was a GNU extension before that. Therefore we can't rely on it, but can fall back to the