Re: [PATCH 7/7] merge: add --rename-notes

2016-01-22 Thread Junio C Hamano
Duy Nguyen writes: > The problem with indexing notes tree by blob is how the user will > manage it. I do not think they have to be incompatible goals. Allowing the user to specify "at this commit, this path was moved to that path" may be a good thing. But at the same time, using a better data

Re: [PATCH 7/7] merge: add --rename-notes

2016-01-21 Thread Duy Nguyen
On Fri, Jan 22, 2016 at 12:53 AM, Junio C Hamano wrote: > This uses _all_ merge notes attached to _any_ commit in the history, > without even checking if the commit is involved in the current merge > being done? How would that be useful? > > I also suspect that the data structure to keep track re

Re: [PATCH 7/7] merge: add --rename-notes

2016-01-21 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > +/* > + * Traverse through the given notes tree, convert all "path to path" > + * rename lines into "blob to blob" and return it. If cache_file is > + * non-NULL, return it's content if still valid. Otherwise save the > + * new content in it. > + */ > +static void