Re: [PATCH 6/8] reflog_expire(): ignore --updateref for symbolic references

2015-02-13 Thread Michael Haggerty
On 02/12/2015 10:54 PM, Jeff King wrote: > On Mon, Feb 09, 2015 at 10:12:42AM +0100, Michael Haggerty wrote: > >> if (!(flags & EXPIRE_REFLOGS_DRY_RUN)) { >> +/* >> + * It doesn't make sense to adjust a reference pointed >> + * to by a symbolic ref based on

Re: [PATCH 6/8] reflog_expire(): ignore --updateref for symbolic references

2015-02-12 Thread Jeff King
On Mon, Feb 09, 2015 at 10:12:42AM +0100, Michael Haggerty wrote: > if (!(flags & EXPIRE_REFLOGS_DRY_RUN)) { > + /* > + * It doesn't make sense to adjust a reference pointed > + * to by a symbolic ref based on expiring entries in > + * the s

Re: [PATCH 6/8] reflog_expire(): ignore --updateref for symbolic references

2015-02-12 Thread Junio C Hamano
Michael Haggerty writes: > This is a pretty exotic usage. I can't think of any real-life use case > for using "--updateref" together with a symbolic reference. In our > entire code base, "--updateref" is only used a single time, in > "git-stash.sh", and that is always for "refs/stash", which is n

Re: [PATCH 6/8] reflog_expire(): ignore --updateref for symbolic references

2015-02-12 Thread Stefan Beller
On Thu, Feb 12, 2015 at 8:08 AM, Michael Haggerty wrote: > On 02/11/2015 01:44 AM, Stefan Beller wrote: >> On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty >> wrote: >> >>> If we are expiring reflog entries for a symbolic reference, then how >>> should --updateref be handled if the newest reflog

Re: [PATCH 6/8] reflog_expire(): ignore --updateref for symbolic references

2015-02-12 Thread Michael Haggerty
On 02/11/2015 01:44 AM, Stefan Beller wrote: > On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty wrote: > >> If we are expiring reflog entries for a symbolic reference, then how >> should --updateref be handled if the newest reflog entry is expired? >> >> Option 1: Update the referred-to reference

Re: [PATCH 6/8] reflog_expire(): ignore --updateref for symbolic references

2015-02-10 Thread Stefan Beller
On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty wrote: > If we are expiring reflog entries for a symbolic reference, then how > should --updateref be handled if the newest reflog entry is expired? > > Option 1: Update the referred-to reference. (This is what the current > code does.) This doesn'

[PATCH 6/8] reflog_expire(): ignore --updateref for symbolic references

2015-02-09 Thread Michael Haggerty
If we are expiring reflog entries for a symbolic reference, then how should --updateref be handled if the newest reflog entry is expired? Option 1: Update the referred-to reference. (This is what the current code does.) This doesn't make sense, because the referred-to reference has its own reflog,