Re: [PATCH 6/7] diff.c: decouple white space treatment from move detection algorithm

2018-04-24 Thread Stefan Beller
Hi Jonathan, On Tue, Apr 24, 2018 at 3:00 PM, Jonathan Tan wrote: > On Tue, 24 Apr 2018 14:03:29 -0700 > Stefan Beller wrote: > >> As we change the default, we'll adjust the tests. > > This statement is probably better written as: > > In some existing tests, options like --ignore-space-at-eol

Re: [PATCH 6/7] diff.c: decouple white space treatment from move detection algorithm

2018-04-24 Thread Jonathan Tan
On Tue, 24 Apr 2018 14:03:29 -0700 Stefan Beller wrote: > As we change the default, we'll adjust the tests. This statement is probably better written as: In some existing tests, options like --ignore-space-at-eol were used to control the color of the output. They have been updated to use

[PATCH 6/7] diff.c: decouple white space treatment from move detection algorithm

2018-04-24 Thread Stefan Beller
In the original implementation of the move detection logic the choice for ignoring white space changes is the same for the move detection as it is for the regular diff. Some cases came up where different treatment would have been nice. Allow the user to specify that whitespace should be ignored d