Re: [PATCH 6/7] delta_base_cache: use hashmap.h

2016-08-23 Thread Junio C Hamano
Jeff King writes: > So while the value for that case _isn't_ as good as the > optimal one measured above (which was 2048 entries), given > the bouncing I'm hesitant to suggest that 2048 is any kind > of optimum (not even for linux.git, let alone as a general > rule). The generic hashmap has the a

[PATCH 6/7] delta_base_cache: use hashmap.h

2016-08-22 Thread Jeff King
The fundamental data structure of the delta base cache is a hash table mapping pairs of "(packfile, offset)" into structs containing the actual object data. The hash table implementation dates back to e5e0161 (Implement a simple delta_base cache, 2007-03-17), and uses a fixed-size table. The curren