Re: [PATCH 6/7] completion: fix expansion issue in __gitcomp()

2012-11-17 Thread SZEDER Gábor
On Sat, Nov 17, 2012 at 12:39:24PM +0100, Felipe Contreras wrote: > On Sat, Nov 17, 2012 at 12:05 PM, SZEDER Gábor wrote: > > > -# Generates completion reply with compgen, appending a space to possible > > -# completion words, if necessary. > > +# Generates completion reply for the word in $cur,

Re: [PATCH 6/7] completion: fix expansion issue in __gitcomp()

2012-11-17 Thread Felipe Contreras
On Sat, Nov 17, 2012 at 12:05 PM, SZEDER Gábor wrote: > -# Generates completion reply with compgen, appending a space to possible > -# completion words, if necessary. > +# Generates completion reply for the word in $cur, appending a space to > +# possible completion words, if necessary. > # It a

[PATCH 6/7] completion: fix expansion issue in __gitcomp()

2012-11-17 Thread SZEDER Gábor
The compgen Bash-builtin performs expansion on all words in the wordlist given to its -W option, breaking Git's completion script when words passed to __gitcomp() contain expandable substrings. In __gitcomp() we only use a small subset ot compgen's functionality, namely the filtering of matching p