Re: [PATCH 6/6] wildmatch test: create & test files on disk in addition to in-memory

2017-12-24 Thread Johannes Sixt
Am 24.12.2017 um 12:06 schrieb Ævar Arnfjörð Bjarmason: On Sun, Dec 24 2017, Johannes Sixt jotted: Am 23.12.2017 um 22:30 schrieb Ævar Arnfjörð Bjarmason: + printf '%s' '$text' >expect && There are no single-quotes in any $text instances, right? There's not, bu

Re: [PATCH 6/6] wildmatch test: create & test files on disk in addition to in-memory

2017-12-24 Thread Ævar Arnfjörð Bjarmason
On Sun, Dec 24 2017, Johannes Sixt jotted: > Am 23.12.2017 um 22:30 schrieb Ævar Arnfjörð Bjarmason: >> Signed-off-by: Ævar Arnfjörð Bjarmason >> --- >> a[]b | 0 >> t/t3070-wildmatch.sh | 336 >> --- >> 2 files changed, 319

Re: [PATCH 6/6] wildmatch test: create & test files on disk in addition to in-memory

2017-12-24 Thread Johannes Sixt
Am 23.12.2017 um 22:30 schrieb Ævar Arnfjörð Bjarmason: > Signed-off-by: Ævar Arnfjörð Bjarmason > --- > a[]b | 0 > t/t3070-wildmatch.sh | 336 > --- > 2 files changed, 319 insertions(+), 17 deletions(-) > create mode 100644

[PATCH 6/6] wildmatch test: create & test files on disk in addition to in-memory

2017-12-23 Thread Ævar Arnfjörð Bjarmason
There has never been any full roundtrip testing of what git-ls-files and other functions that use wildmatch() actually do, rather we've been satisfied with just testing the underlying C function. Due to git-ls-files and friends having their own codepaths before they call wildmatch() there's someti