Re: [PATCH 6/6] template: Fix comment indentation in pre-rebase hook

2013-07-14 Thread Jonathan Nieder
Richard Hartmann wrote: > The other hooks use two whitespace for indentation instead of tabs > to signify code in the example/echo output. > Follow the same layout in templates/hooks--pre-rebase.sample I don't understand the point of this one. Is it just consistency for the sake of consistency?

[PATCH 6/6] template: Fix comment indentation in pre-rebase hook

2013-07-14 Thread Richard Hartmann
The other hooks use two whitespace for indentation instead of tabs to signify code in the example/echo output. Follow the same layout in templates/hooks--pre-rebase.sample Based on d153a68bebfabc1db5241d02ee75fa5cb4538ab0 in original patch series from 2013-06-10. Signed-off-by: Richard Hartmann

Re: [PATCH 6/6] template: Fix comment indentation in pre-rebase hook

2013-06-10 Thread Richard Hartmann
ng that it can be > configured out if it is unwanted. > > Other than that, I think it is a good addition. Will update once I know the complete TODO. > [PATCH 5/6] templates: Fix ASCII art in pre-rebase hook > > Good, but see Peff's comments on the explanation. OK. &

Re: [PATCH 6/6] template: Fix comment indentation in pre-rebase hook

2013-06-10 Thread Junio C Hamano
hinting that it can be configured out if it is unwanted. Other than that, I think it is a good addition. [PATCH 5/6] templates: Fix ASCII art in pre-rebase hook Good, but see Peff's comments on the explanation. [PATCH 6/6] template: Fix comment indentation in pre-rebase hook Aft

Re: [PATCH 6/6] template: Fix comment indentation in pre-rebase hook

2013-06-10 Thread Richard Hartmann
On Mon, Jun 10, 2013 at 9:52 PM, Junio C Hamano wrote: > I think offsetting the actual commands to the right is correct, but > "if these match" and "if this is empty" should be flushed to left as > this patch shows. I actually considered this and decided against it as it seemed to be deliberate

Re: [PATCH 6/6] template: Fix comment indentation in pre-rebase hook

2013-06-10 Thread Junio C Hamano
Richard Hartmann writes: > The other hooks use two whitespace for indentation instead of tabs > to signify code in the example/echo output. > Follow the same layout in templates/hooks--pre-rebase.sample > > Signed-off-by: Richard Hartmann > --- > templates/hooks--pre-rebase.sample | 10 +-

[PATCH 6/6] template: Fix comment indentation in pre-rebase hook

2013-06-10 Thread Richard Hartmann
The other hooks use two whitespace for indentation instead of tabs to signify code in the example/echo output. Follow the same layout in templates/hooks--pre-rebase.sample Signed-off-by: Richard Hartmann --- templates/hooks--pre-rebase.sample | 10 +- 1 file changed, 5 insertions(+), 5