Re: [PATCH 6/6] sparse: Fix mingw_main() argument number/type errors

2013-04-29 Thread Ramsay Jones
René Scharfe wrote: > Am 28.04.2013 21:31, schrieb Junio C Hamano: >> René Scharfe writes: >> >>> Why not take the opposite direction with a patch like this? >>> ... >>> diff --git a/compat/mingw.h b/compat/mingw.h >>> index 389ae01..74e7b87 100644 >>> --- a/compat/mingw.h >>> +++ b/compat/mingw.h

Re: [PATCH 6/6] sparse: Fix mingw_main() argument number/type errors

2013-04-29 Thread Ramsay Jones
René Scharfe wrote: > Am 27.04.2013 21:19, schrieb Ramsay Jones: >> In order to suppress these warnings, since both of the main >> functions need to be declared with the same prototype, we >> change the declaration of the 9 main functions, thus: >> >> int main(int argc, char **argv) > > Why n

Re: [PATCH 6/6] sparse: Fix mingw_main() argument number/type errors

2013-04-29 Thread René Scharfe
Am 28.04.2013 21:31, schrieb Junio C Hamano: René Scharfe writes: Why not take the opposite direction with a patch like this? ... diff --git a/compat/mingw.h b/compat/mingw.h index 389ae01..74e7b87 100644 --- a/compat/mingw.h +++ b/compat/mingw.h @@ -452,11 +452,11 @@ int xwcstoutf(char *utf,

Re: [PATCH 6/6] sparse: Fix mingw_main() argument number/type errors

2013-04-28 Thread Junio C Hamano
René Scharfe writes: > Why not take the opposite direction with a patch like this? > ... > diff --git a/compat/mingw.h b/compat/mingw.h > index 389ae01..74e7b87 100644 > --- a/compat/mingw.h > +++ b/compat/mingw.h > @@ -452,11 +452,11 @@ int xwcstoutf(char *utf, const wchar_t *wcs, size_t > utfl

Re: [PATCH 6/6] sparse: Fix mingw_main() argument number/type errors

2013-04-27 Thread René Scharfe
Am 27.04.2013 21:19, schrieb Ramsay Jones: > In order to suppress these warnings, since both of the main > functions need to be declared with the same prototype, we > change the declaration of the 9 main functions, thus: > > int main(int argc, char **argv) Why not take the opposite direction

[PATCH 6/6] sparse: Fix mingw_main() argument number/type errors

2013-04-27 Thread Ramsay Jones
Sparse issues 68 errors (two errors for each main() function) such as the following: SP git.c git.c:510:5: error: too many arguments for function mingw_main git.c:510:5: error: symbol 'mingw_main' redeclared with different type \ (originally declared at git.c:510) - different argume