Re: [PATCH 6/6] grep: obey --textconv for the case rev:path

2013-04-20 Thread Jeff King
On Sat, Apr 20, 2013 at 04:42:49PM +0200, Michael J Gruber wrote: > > And this mass of almost-the-same functions is gross, too, especially > > given that the object_context contains a mode itself. > > Well, it's just providing different ways to call into the one and only > function, in order to s

Re: [PATCH 6/6] grep: obey --textconv for the case rev:path

2013-04-20 Thread Michael J Gruber
Jeff King venit, vidit, dixit 20.04.2013 06:24: > On Fri, Apr 19, 2013 at 06:44:49PM +0200, Michael J Gruber wrote: > >> @@ -820,12 +820,13 @@ int cmd_grep(int argc, const char **argv, const char >> *prefix) >> for (i = 0; i < argc; i++) { >> const char *arg = argv[i]; >>

Re: [PATCH 6/6] grep: obey --textconv for the case rev:path

2013-04-19 Thread Jeff King
On Fri, Apr 19, 2013 at 06:44:49PM +0200, Michael J Gruber wrote: > @@ -820,12 +820,13 @@ int cmd_grep(int argc, const char **argv, const char > *prefix) > for (i = 0; i < argc; i++) { > const char *arg = argv[i]; > unsigned char sha1[20]; > + struct

[PATCH 6/6] grep: obey --textconv for the case rev:path

2013-04-19 Thread Michael J Gruber
Make "grep" obey the "--textconv" option also for the object case, i.e. when used with an argument "rev:path". Signed-off-by: Michael J Gruber --- builtin/grep.c | 11 ++- object.c | 26 -- object.h | 2 ++ t/t7008-grep-binary.