Re: [PATCH 6/6] format-patch --notes: show notes after three-dashes

2012-10-21 Thread Philip Oakley
From: "Junio C Hamano" "Philip Oakley" writes: From: "Junio C Hamano" When inserting the note after the commit log message to format-patch output, add three dashes before the note. Record the fact that we did so in the rev_info and omit showing duplicated three dashes in the usual codepath

Re: [PATCH 6/6] format-patch --notes: show notes after three-dashes

2012-10-19 Thread Junio C Hamano
Junio C Hamano writes: > As long as what it does is explained in format-patch, that is fine. > > I do not think this deserves to be in the SubmittingPatches. We do > tell people to hide "here is the context of the change" additional > explanation after three dashes, but how the submitters prepar

Re: [PATCH 6/6] format-patch --notes: show notes after three-dashes

2012-10-18 Thread Junio C Hamano
"Philip Oakley" writes: > From: "Junio C Hamano" >> When inserting the note after the commit log message to format-patch >> output, add three dashes before the note. Record the fact that we >> did so in the rev_info and omit showing duplicated three dashes in >> the usual codepath that is used

Re: [PATCH 6/6] format-patch --notes: show notes after three-dashes

2012-10-18 Thread Philip Oakley
From: "Junio C Hamano" When inserting the note after the commit log message to format-patch output, add three dashes before the note. Record the fact that we did so in the rev_info and omit showing duplicated three dashes in the usual codepath that is used when notes are not being shown. Signe

[PATCH 6/6] format-patch --notes: show notes after three-dashes

2012-10-17 Thread Junio C Hamano
When inserting the note after the commit log message to format-patch output, add three dashes before the note. Record the fact that we did so in the rev_info and omit showing duplicated three dashes in the usual codepath that is used when notes are not being shown. Signed-off-by: Junio C Hamano