Re: [PATCH 5/9] t1308: relax the test verifying that empty alias values are disallowed

2017-06-09 Thread Junio C Hamano
Johannes Schindelin writes: > We are about to change the way aliases are expanded, to use the early > config machinery. > > This machinery reports errors in a slightly different manner than the > cached config machinery. > > Let's not get hung up by the precise wording of the message mentioning >

Re: [PATCH 5/9] t1308: relax the test verifying that empty alias values are disallowed

2017-06-08 Thread Brandon Williams
On 06/08, Johannes Schindelin wrote: > Hi Brandon, > > On Wed, 7 Jun 2017, Brandon Williams wrote: > > > On 06/07, Johannes Schindelin wrote: > > > We are about to change the way aliases are expanded, to use the early > > > config machinery. > > > > > > This machinery reports errors in a slightl

Re: [PATCH 5/9] t1308: relax the test verifying that empty alias values are disallowed

2017-06-08 Thread Johannes Schindelin
Hi Brandon, On Wed, 7 Jun 2017, Brandon Williams wrote: > On 06/07, Johannes Schindelin wrote: > > We are about to change the way aliases are expanded, to use the early > > config machinery. > > > > This machinery reports errors in a slightly different manner than the > > cached config machinery

Re: [PATCH 5/9] t1308: relax the test verifying that empty alias values are disallowed

2017-06-07 Thread Brandon Williams
On 06/07, Johannes Schindelin wrote: > We are about to change the way aliases are expanded, to use the early > config machinery. > > This machinery reports errors in a slightly different manner than the > cached config machinery. Not a comment on the patch but just a genuine question: Is there an

[PATCH 5/9] t1308: relax the test verifying that empty alias values are disallowed

2017-06-07 Thread Johannes Schindelin
We are about to change the way aliases are expanded, to use the early config machinery. This machinery reports errors in a slightly different manner than the cached config machinery. Let's not get hung up by the precise wording of the message mentioning the lin number. It is really sufficient to