Junio C Hamano writes:
> (4) if it only runs once at the very beginning of the test and sets
> a variable that is named prominently clear what it means and lives
> throughout the test, then we do not even have to say "hopefully" and
> appear lazy and loose to the readers of the test who wonders w
Michael Haggerty writes:
> The possibility is obvious. Are you advocating it?
>
> I considered that approach, but came to the opinion that it would be
> overkill that would only complicate the code for no real advantage,
> given that (1) I picked a name that is pretty implausible for an
> existi
On 09/07/2012 01:08 AM, Junio C Hamano wrote:
> mhag...@alum.mit.edu writes:
>
>> From: Michael Haggerty
>>
>> There is currently a bug: if passed an absolute top-level path that
>> doesn't exist (e.g., "/foo") it incorrectly interprets the path as a
>> relative path (e.g., returns "$(pwd)/foo").
mhag...@alum.mit.edu writes:
> From: Michael Haggerty
>
> There is currently a bug: if passed an absolute top-level path that
> doesn't exist (e.g., "/foo") it incorrectly interprets the path as a
> relative path (e.g., returns "$(pwd)/foo"). So mark the test as
> failing.
>
> Signed-off-by: Mic
On 09/05/2012 10:40 AM, Johannes Sixt wrote:
> Am 9/4/2012 10:14, schrieb mhag...@alum.mit.edu:
>> From: Michael Haggerty
>>
>> There is currently a bug: if passed an absolute top-level path that
>> doesn't exist (e.g., "/foo") it incorrectly interprets the path as a
>> relative path (e.g., return
Am 9/4/2012 10:14, schrieb mhag...@alum.mit.edu:
> From: Michael Haggerty
>
> There is currently a bug: if passed an absolute top-level path that
> doesn't exist (e.g., "/foo") it incorrectly interprets the path as a
> relative path (e.g., returns "$(pwd)/foo"). So mark the test as
> failing.
>
From: Michael Haggerty
There is currently a bug: if passed an absolute top-level path that
doesn't exist (e.g., "/foo") it incorrectly interprets the path as a
relative path (e.g., returns "$(pwd)/foo"). So mark the test as
failing.
Signed-off-by: Michael Haggerty
---
t/t-basic.sh | 12 ++
7 matches
Mail list logo