Re: [PATCH 5/7] diff.c: add a blocks mode for moved code detection

2018-04-24 Thread Jonathan Tan
On Tue, 24 Apr 2018 15:37:51 -0700 Stefan Beller wrote: > These can be combined independently, so would > you expect the user to expect two options for them? > For example "--color-moved=zebra" could be split > into "--skip-small --alternate-blocks" Yes, this is a good explanation. Reusing your

Re: [PATCH 5/7] diff.c: add a blocks mode for moved code detection

2018-04-24 Thread Stefan Beller
On Tue, Apr 24, 2018 at 2:50 PM, Jonathan Tan wrote: > On Tue, 24 Apr 2018 14:03:28 -0700 > Stefan Beller wrote: > >> Suggested-by: Ævar Arnfjörð Bjarmason >> (https://public-inbox.org/git/87o9j0uljo@evledraar.gmail.com/) >> Signed-off-by: Stefan Beller > > Firstly, I don't know if this is

Re: [PATCH 5/7] diff.c: add a blocks mode for moved code detection

2018-04-24 Thread Jonathan Tan
On Tue, 24 Apr 2018 14:03:28 -0700 Stefan Beller wrote: > Suggested-by: Ævar Arnfjörð Bjarmason > (https://public-inbox.org/git/87o9j0uljo@evledraar.gmail.com/) > Signed-off-by: Stefan Beller Firstly, I don't know if this is the right solution- as written in the linked e-mail [1], the iss

[PATCH 5/7] diff.c: add a blocks mode for moved code detection

2018-04-24 Thread Stefan Beller
The new "blocks" mode provides a middle ground between plain and zebra. It is as intuitive (few colors) as plain, but still has the requirement for a minimum of lines/characters to count a block as moved. Suggested-by: Ævar Arnfjörð Bjarmason (https://public-inbox.org/git/87o9j0uljo@evledraa