Re: [PATCH 5/7] delta_base_cache: drop special treatment of blobs

2016-08-23 Thread Junio C Hamano
Jeff King writes: > Let's run the same numbers without caring about object type > at all (i.e., one LRU list, and always evicting whatever is > at the head, regardless of type). > ... > So it seems like a clear winner, and that's what this patch > implements. > > Signed-off-by: Jeff King > ---

[PATCH 5/7] delta_base_cache: drop special treatment of blobs

2016-08-22 Thread Jeff King
When the delta base cache runs out of allowed memory, it has to drop entries. It does so by walking an LRU list, dropping objects until we are under the memory limit. But we actually walk the list twice: once to drop blobs, and then again to drop other objects (which are generally trees). This come